WIP - Security Hardening: Guess sensitive attributes by name in addition to API checks#984
Draft
oleg-nenashev wants to merge 1 commit intojenkinsci:masterfrom
Draft
Conversation
Member
Author
|
retriggering CI |
MRamonLeon
approved these changes
Aug 16, 2019
Member
Author
|
Test failure is real |
Member
|
@oleg-nenashev Do you plan to pick this up again? Or shall we close it? I don't remember seeing new issues about this at all |
Member
Author
|
Let's keep it open for now. Need to do a bigger scrub
…On Sat, 7 Aug 2021, 16:31 Tim Jacomb, ***@***.***> wrote:
@oleg-nenashev <https://github.com/oleg-nenashev> Do you plan to pick
this up again? Or shall we close it? I don't remember seeing new issues
about this at all
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#984 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIGFUKJ2GL6PPA7SOFDT3U7VBANCNFSM4ILI4Z6A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the SECURITY-1279, SECURITY-1458, SECURITY-1497 fixes in JCasC 1.25 and 1.27. Although these fixes provide a decent level of security for attributes where
Secretis somehow referenced in plugin APIs, there is still a gap for plugins which do not useSecretAPI at all. If passwords are stored in plain text (like in plugins references in this advisory) and retrieved as Strings in API, there is nothing JCasC can do about it at the moment. It makes JCasC use-cases impacted by vulnerabilities in other plugins.This change...
Secretexports are encrypted, and nothing changes thereAttributes to indicate that a field is encryptedProxyConfiguratorwhich is caused by the changes. It demonstrates the use of new APIsYour checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.